Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide auto-sanitize option when Native theme support is built-in #1358

Closed
westonruter opened this issue Aug 27, 2018 · 2 comments
Closed

Hide auto-sanitize option when Native theme support is built-in #1358

westonruter opened this issue Aug 27, 2018 · 2 comments
Labels
Bug Something isn't working Good First Issue
Milestone

Comments

@westonruter
Copy link
Member

When theme support is not built-in and the user selects the Native template mode, the auto-sanitize checkbox is hidden since it is forced. However, this isn't currently working when theme support is built-in via add_theme_support('amp'):

image

@westonruter westonruter added Bug Something isn't working Good First Issue labels Aug 27, 2018
@westonruter
Copy link
Member Author

The problem lies here:

https://github.com/Automattic/amp-wp/blob/0401d5e971aa29c3fc2c9981af41ca51e7d807cf/includes/options/class-amp-options-menu.php#L261-L262

When AMP support is built-in the jQuery( 'input[type=radio][name="amp-options[theme_support]"]' ) result is empty because there are no template mode radio buttons.

@kienstra
Copy link
Contributor

Moving To 'Ready For Merging'

If it's alright, I'm moving this to 'Ready For Merging,' as I don't think it needs functional testing. Feel free to move it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue
Projects
None yet
Development

No branches or pull requests

2 participants