Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or replace gutenberg_get_jed_locale_data() usage #1618

Closed
swissspidy opened this issue Nov 15, 2018 · 3 comments
Closed

Rename or replace gutenberg_get_jed_locale_data() usage #1618

swissspidy opened this issue Nov 15, 2018 · 3 comments
Assignees
Labels
Bug Something isn't working Integration: Gutenberg
Milestone

Comments

@swissspidy
Copy link
Collaborator

gutenberg_get_jed_locale_data() is now wp_get_jed_locale_data() in WordPress core.

The plugin currently fatals because of that.

The function should be renamed in the plugin and perhaps even considered to replaced in WP 5.0+ as per https://make.wordpress.org/core/2018/11/09/new-javascript-i18n-support-in-wordpress/.

See also #1604.

@swissspidy swissspidy added Bug Something isn't working Integration: Gutenberg labels Nov 15, 2018
@swissspidy
Copy link
Collaborator Author

Either way, it doesn't hurt to add some function_exists() checks as is already done in \AMP_Post_Meta_Box.

@westonruter westonruter added this to the v1.0 milestone Nov 16, 2018
@westonruter westonruter self-assigned this Nov 16, 2018
@westonruter
Copy link
Member

And the function has now been removed from core. We need to address this again.

See https://core.trac.wordpress.org/changeset/43910

@westonruter westonruter reopened this Nov 21, 2018
@westonruter
Copy link
Member

@swissspidy Can you figure out what needs to be done here for the 1.0-RC3 release tomorrow? /cc @kienstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Integration: Gutenberg
Projects
None yet
Development

No branches or pull requests

3 participants