Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notice that informs users that their active theme and plugins may not be fully compatible with the new native/paired modes #1732

Closed
3 tasks
alcurrie opened this issue Dec 12, 2018 · 5 comments
Labels
P1 Medium priority WS:UX Work stream for UX/Front-end

Comments

@alcurrie
Copy link

As a site owner installing the AMP plugin for the first time, I'd like to see a notice that lets me know if my active theme and/or plugins may not be fully compatible with the new native/paired mode

  • AC 1: After that AMP 1.0 plugin is installed, check whether the current active theme and all active plugins, are compatible with native/paired AMP modes
  • AC 2: If the active theme and/or 1 or more installed plugins are not confirmed to be compatible, display a notice prominently in the WP Admin informing the user that their active theme and/or plugins may not be fully compatible with the new native/paired mode
    • AC 3: Notice should specify theme name, and all plugins not confirmed to be compatible.
@alcurrie alcurrie added this to the v 1.0.2 milestone Dec 12, 2018
@alcurrie
Copy link
Author

@westonruter - as discussed I added issue and high level AC to v 1.0.2 milestone

@alcurrie alcurrie reopened this Dec 12, 2018
@westonruter
Copy link
Member

We should also add a notice to the readme that makes clear that custom JavaScript will be stripped from AMP responses. So if they have ads that require JS, then they'll need to use amp-ad wherever an ad placement occurs.

@westonruter westonruter removed this from the v 1.0.2 milestone Jan 17, 2019
@westonruter
Copy link
Member

Related: #2313. We should highlight the AMP-compatible themes and plugins from the start prior to installation.

Also related is building a compatibility database of plugins that are known to be compatible or incompatible.

@amedina amedina added UX Phase 2 P1 Medium priority labels May 14, 2020
@kmyram kmyram added the WS:UX Work stream for UX/Front-end label May 15, 2020
@jwold
Copy link
Collaborator

jwold commented Aug 5, 2020

@westonruter is this still a relevant issue with the new work we've done on the onboarding wizard?

@westonruter
Copy link
Member

Correct. This is obsolete, or it will be obsolete when the site scanning features are implemented in #4719/#4795.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority WS:UX Work stream for UX/Front-end
Projects
None yet
Development

No branches or pull requests

5 participants