Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 5.1 Compatibility #1906

Closed
swissspidy opened this issue Feb 27, 2019 · 4 comments
Closed

WordPress 5.1 Compatibility #1906

swissspidy opened this issue Feb 27, 2019 · 4 comments
Milestone
v1.1

Comments

@swissspidy
Copy link
Collaborator

Previously: #1604

  • Verify that everything still works as expected
  • Bump 'Tested up to' value in readme to 5.1.

If we can verify that 1.0.2 works fine with WordPress 5.1, we can just bump the version number on WordPress.org without having to release a new version of the plugin.

This would reassure our users that the plugin is safe to use with WordPress 5.1.
@westonruter
Copy link
Member

Bump it just by making a new commit on the latest SVN tag?

@swissspidy
Copy link
Collaborator Author

Yep, the commit would be for the readme in the 1.0.2 tag

@westonruter
Copy link
Member

I've been doing all development of the plugin using trunk, and I'm using the plugin on my own blog which is on WP 5.1, so it has indeed been tested in 5.1. I'll bump it.

@westonruter westonruter added this to the v1.1 milestone Mar 4, 2019
@westonruter westonruter mentioned this issue Mar 4, 2019
Merged
@westonruter
Copy link
Member

Done: https://plugins.trac.wordpress.org/changeset/2044249/amp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@westonruter @swissspidy