Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global / per Story Slide Duration Options #1995

Closed
miina opened this issue Mar 20, 2019 · 4 comments · Fixed by #3201
Closed

Global / per Story Slide Duration Options #1995

miina opened this issue Mar 20, 2019 · 4 comments · Fixed by #3201
Milestone

Comments

@miina
Copy link
Contributor

miina commented Mar 20, 2019

AC: User can set the slide duration options either globally or per story.
AC: The global / per story setting can be overridden per slide.

Investigate options for setting the slide duration per story or globally. This way the user wouldn't have to set each slide separately in the likely use case of wanting to use auto or media for all slides.

@swissspidy
Copy link
Collaborator

Note that it's finally possible to actually extend the document sidebar with the upcoming new Gutenberg version.

See WordPress/gutenberg#13361 / WordPress/gutenberg#13357

@swissspidy
Copy link
Collaborator

@dero The PR is still set to draft – it's not clear to me whether this is now ready for review or still WIP. Can you clarify?

@dero
Copy link
Contributor

dero commented Sep 11, 2019

Summary for QA:

This PR introduces a concept of global settings and story settings.

  • Global settings: set on AMP plugin settings page, applied as defaults to every new story.
  • Story settings: set on a story post, applied as defaults to every new page.
  • Page settings: set on a page block, applied to that block only.

Test instructions:

  1. Go to AMP plugin settings page and enable the Stories experience.
  2. Change the values in the Stories Settings field and check the values persist upon saving.
  3. Create a new story and notice a "Story Settings" panel in the "Document" tab.
  4. Verify that values in that panel match what was set globally in step 2.
  5. Click the first page and on the "Block" tab verify that the values in the "Page Settings" box match the "Story Settings".
  6. Change the "Story Settings" to something else in the "Document" tab.
  7. Verify that the "Page Settings" in the "Block" tab did not change.
  8. Create a new page.
  9. Verify that the "Page Settings" in the "Block" tab are equal to what was set in step 6.
  10. Create a new page.
  11. Change the "Page Settings" in the "Block" tab for that page to something else.
  12. Check that other pages were not affected and their "Page Settings" stayed intact.
  13. Check that the "Story Settings" in the "Document" tab remained unchanged.
  14. Finish the story and publish it.
  15. Verify that the advancement options are applied correctly on the front-end.

Screencast: https://www.youtube.com/watch?v=TppJ96XE-qU

@swissspidy swissspidy changed the title [AMP Stories] Global / per Story Slide Duration Options Global / per Story Slide Duration Options Sep 11, 2019
@csossi
Copy link

csossi commented Sep 13, 2019

Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants