Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force amp-img > noscript > img fallbacks to have HTTPS src/srcset #2126

Closed
westonruter opened this issue Apr 13, 2019 · 0 comments · Fixed by #2131
Closed

Force amp-img > noscript > img fallbacks to have HTTPS src/srcset #2126

westonruter opened this issue Apr 13, 2019 · 0 comments · Fixed by #2131
Milestone

Comments

@westonruter
Copy link
Member

If an image is in post content with an http protocol, this will persist into the noscript > img fallback when it is converted to amp-img (see #1832). While an amp-img allows http protocol, the noscript > img does not. See fix to AMP spec here ampproject/amphtml#21686. To prevent a lot of validation errors from appearing for sites that have HTTP images, we should consider automatically converting the noscript > img elements to HTTPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant