Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Top Toolbar #2179

Closed
2 of 3 tasks
swissspidy opened this issue Apr 24, 2019 · 4 comments
Closed
2 of 3 tasks

Force Top Toolbar #2179

swissspidy opened this issue Apr 24, 2019 · 4 comments
Milestone

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Apr 24, 2019

Having the block toolbar attached to the block makes editing quite cumbersome when they can be resized (very small, overlapping other blocks) and rotated (hard to edit, warrants disabling block rotation) within a page.

It makes more sense to force the Top Toolbar to be active at all times for a better editing experience.

With this plus #1974, we're getting to a point where we don't need to show any block toolbar within a page anymore, but only the block itself.

This will make it easier to have accurate positioning within a page as well. (Think scale() in CSS)

Suggestion:

  • Filter editor settings to make sure fixedToolbar is always enabled.
  • Maybe subscribe() to state changes to turn fixedToolbar on it somehow gets deactivated through something else.
  • Hide Fixed Toolbar option using CSS.
@swissspidy
Copy link
Collaborator Author

Created an issue upstream: WordPress/gutenberg#15264

@swissspidy swissspidy changed the title [AMP Stories] Force Top Toolbar Force Top Toolbar Apr 30, 2019
@swissspidy
Copy link
Collaborator Author

Related: #2231

@swissspidy
Copy link
Collaborator Author

Testing instructions

  1. Create new story with a few blocks
  2. Verify that the block toolbar with block controls lives at the top of the page
  3. Click on three dots in the upper right corner
  4. Verify that there is no menu item to change the toolbar position

@csossi
Copy link

csossi commented May 14, 2019

Verified in QA

  • option to move not appearing in Options
    Example - toolbar for Text block at top of page:
    image

Example - toolbar for Image block at top of page:
image

@csossi csossi removed their assignment May 14, 2019
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants