Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block style "broken" with the latest Gutenberg updates #2703

Closed
miina opened this issue Jun 28, 2019 · 4 comments · Fixed by #2778
Closed

Block style "broken" with the latest Gutenberg updates #2703

miina opened this issue Jun 28, 2019 · 4 comments · Fixed by #2778
Labels
Bug Something isn't working

Comments

@miina
Copy link
Contributor

miina commented Jun 28, 2019 •
edited
Loading

To reproduce:

  • Update to the latest Gutenberg (e.g. from repo)
  • Open the template Inserter
  • Add the Tip template

This can be seen especially well when using narrow blocks.

Result:
Screenshot 2019-06-28 at 12 23 21
Screenshot 2019-06-28 at 12 23 36
Screenshot 2019-06-28 at 12 25 04

EDIT: Also the templates seem to be broken, potentially related to style changes upstream.
@miina miina added Bug Something isn't working AMP Stories labels Jun 28, 2019
@miina miina self-assigned this Jul 10, 2019
@miina
Copy link
Contributor Author

miina commented Jul 10, 2019

Looks like the template previews look broken due to this styling here which removes our transform:
Screenshot 2019-07-10 at 13 53 57

@miina
Copy link
Contributor Author

miina commented Jul 10, 2019 •
edited
Loading

Note that this affects reordering as well.

@miina miina mentioned this issue Jul 10, 2019
Merged
@miina
Copy link
Contributor Author

miina commented Jul 11, 2019 •
edited
Loading

Instructions for testing:

  • Verify that the template preview doesn't look broken.
  • Verify that a text block doesn't have noticeable extra margin between the content and its borders (the padding/margin should be around 7px and not 28px).
  • Set rotation to a block, save and refresh. Verify that the block displays rotated in the editor.

@miina miina assigned csossi and unassigned miina Jul 12, 2019
@csossi
Copy link

csossi commented Jul 15, 2019

Verified in QA

@csossi csossi removed their assignment Jul 15, 2019
@swissspidy swissspidy mentioned this issue Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Style fixes for upstream updates ampproject/amp-wp
3 participants
@miina @csossi @MackenzieHartung