You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe this is due to the fact that amp-paired-browsing-client depends on both wp-dom-ready and wp-polyfill but only the former is being polyfilled for WordPress 4.9:
In other words, there is no polyfill for the polyfills.
Three options I see here:
Increase minimum WP version to 5.0 and eliminate these pre-Gutenberg polyfills altogether.
Polyfill the polyfills.
Prevent paired browsing from being available in WordPress 4.9.
I've gone ahead and removed the test case in 64a8051, but this will need to be fixed for v1.5 in a separate PR. That PR can revert this commit to re-add those tests.
Expected Behaviour
Paired browsing should either be not available or the minimum version of WordPress should be bumped.
Steps to reproduce
Try to access paired browsing in WordPress 4.9.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered:
I believe adding a polyfill for the polyfills would be the safest option here, but increasing the minimum WP version to 5.0 is also an interesting option to investigate. If information is available to analyze the current installs of the plugin by WP version that would make the decision of increasing said version much easier.
Bug Description
Originally reported in #3928 (comment).
There is a conflict in WordPress 4.9 due to the amp-paired-browsing-client not being printed: https://travis-ci.org/ampproject/amp-wp/jobs/625330248#L1062-L1068
I believe this is due to the fact that
amp-paired-browsing-client
depends on bothwp-dom-ready
andwp-polyfill
but only the former is being polyfilled for WordPress 4.9:amp-wp/webpack.config.js
Lines 261 to 263 in 80e70e3
In other words, there is no polyfill for the polyfills.
Three options I see here:
I've gone ahead and removed the test case in 64a8051, but this will need to be fixed for v1.5 in a separate PR. That PR can revert this commit to re-add those tests.
Expected Behaviour
Paired browsing should either be not available or the minimum version of WordPress should be bumped.
Steps to reproduce
Try to access paired browsing in WordPress 4.9.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: