-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve architecture of composing error messages for each validation error code #4071
Labels
Developer Tools
Enhancement
New feature or improvement of an existing one
Groomed
Validation
WS:Core
Work stream for Plugin core
Comments
3 tasks
This is going to naturally fall out from #1420. |
westonruter
changed the title
Add translatable error messages for each error code
Improve architecture of composing error messages for each validation error code
Feb 6, 2020
amedina
added
Developer Tools
Enhancement
New feature or improvement of an existing one
Validation
and removed
Compatibility Tool
labels
Apr 1, 2020
This makes sense to address as part of #3875 when extracting sanitization/validation logic to amp-toolbox-php. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer Tools
Enhancement
New feature or improvement of an existing one
Groomed
Validation
WS:Core
Work stream for Plugin core
Feature description
Add translatable error messages for each specific error code, removing the logic from
\AMP_Validation_Error_Taxonomy::get_error_title_from_code()
and into the respective sanitizer that originated the validation error. Improve structure of validation error to make it easier to construct messages. For example, harmonizenode_attributes
andelement_attributes
to justelement_attributes
.So this is more of an architectural issue rather than providing just providing error message translations, which is already in progress. This involves adding validation error objects.
Related: #3664, #3780, #3817, #1420.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: