Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The attribute 'height' in tag 'amp-iframe' is set to the invalid value #4192

Closed
anonymous-developer-786 opened this issue Jan 29, 2020 · 1 comment

Comments

@anonymous-developer-786

I am facing this issue. Any help will be highly appreciated.
here's the screenshot of google AMP test https://www.screenpresso.com/=pwzqg

@westonruter
Copy link
Member

The issue is this iframe in the non-AMP page:

<iframe width="100%" height="100%" src="//eboundservices.com/ads/video.php" frameborder="0" allowfullscreen="true" webkitallowfullscreen="true" mozallowfullscreen="true"></iframe>

However, when I load your AMP URL in the validator I see no validation error: https://validator.amp.dev/#url=https%3A%2F%2Fwww.anduril.band%2F%3Famp

In fact, now I see:

<amp-iframe src="https://eboundservices.com/ads/video.php" allowfullscreen="" sandbox="allow-scripts allow-same-origin" height="400" width="768"></amp-iframe>

Nevertheless, the issue of height=100% being stripped was fixed recently via #3728. This is not yet released, but you can try a v1.5.0-alpha-20200128T224531Z-6021df7db pre-release build here: amp.zip

This results in the above iframe being rendered as:

<amp-iframe src="https://eboundservices.com/ads/video.php" frameborder="0" allowfullscreen="" layout="fill" sandbox="allow-scripts allow-same-origin"><span placeholder="" class="amp-wp-iframe-placeholder"></span><noscript><iframe width="100%" height="100%" src="https://eboundservices.com/ads/video.php" frameborder="0"></iframe></noscript></amp-iframe>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants