Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Requires plugin header information #4520

Closed
schlessera opened this issue Apr 3, 2020 · 3 comments · Fixed by #4543
Closed

Add Requires plugin header information #4520

schlessera opened this issue Apr 3, 2020 · 3 comments · Fixed by #4543
Assignees
Milestone

Comments

@schlessera
Copy link
Collaborator

Feature description

We should add the requirements into the plugin's file header to let WordPress know what is expected:

 * Requires at least: 5.0
 * Requires PHP:      5.6

Note: I'm not sure which version of WordPress we actually do require since we stripped the AMP Stories component...


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The plugin advertises the correct requirements to WordPress.

Implementation brief

  • Add the following to the plugin file header metadata:
      * Requires at least: 5.0
      * Requires PHP:      5.6

QA testing instructions

Demo

Changelog entry

@westonruter
Copy link
Member

@schlessera Isn't this already present? See:

amp-wp/readme.txt

Lines 4 to 9 in 4193dbc

Requires at least: 4.9
Tested up to: 5.4
Stable tag: 1.5.1
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html
Requires PHP: 5.6

It needs to be in the readme.txt not the plugin bootstrap file, AFAIK. See https://make.wordpress.org/plugins/2017/08/29/minimum-php-version-requirement/

@swissspidy
Copy link
Collaborator

Support for this in the main plugin file was added rather recently. Because in some cases WP only checks that, not the readme.

@westonruter
Copy link
Member

Of course it does! 🤦‍♂

@westonruter westonruter added this to the v1.5.3 milestone Apr 6, 2020
@schlessera schlessera self-assigned this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants