You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While writing the documentation, I'm noticing some minor consistency issues that should be straightened out at the earliest possible convenience.
I'm collecting these here to make a grouped PR for this as a dependency for the docs PR.
The TransformationEngine's first argument Configuration $configuration should be made optional via a poka-yoke, just as the second argument is. This would then fall back to the default out-of-the-box configuration.
The required order of the arguments when a transformer implements both Configurable and MakesRemoteRequests should be swapped, so that it matches the order of the Configuration and RemoteGetRequest arguments in the TransformationEngine's constructor.
Docblocks in FilesystemRemoteGetRequest are copypasta from StubbedRemoteGetRequest and need to be adapted.
The text was updated successfully, but these errors were encountered:
While writing the documentation, I'm noticing some minor consistency issues that should be straightened out at the earliest possible convenience.
I'm collecting these here to make a grouped PR for this as a dependency for the docs PR.
The
TransformationEngine
's first argumentConfiguration $configuration
should be made optional via a poka-yoke, just as the second argument is. This would then fall back to the default out-of-the-box configuration.The required order of the arguments when a transformer implements both
Configurable
andMakesRemoteRequests
should be swapped, so that it matches the order of theConfiguration
andRemoteGetRequest
arguments in theTransformationEngine
's constructor.Docblocks in
FilesystemRemoteGetRequest
are copypasta fromStubbedRemoteGetRequest
and need to be adapted.The text was updated successfully, but these errors were encountered: