Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Optimizer interfaces for consistency #4612

Closed
3 tasks done
schlessera opened this issue Apr 21, 2020 · 0 comments · Fixed by #4614
Closed
3 tasks done

Tweak Optimizer interfaces for consistency #4612

schlessera opened this issue Apr 21, 2020 · 0 comments · Fixed by #4614
Assignees
Labels
Optimizer WS:Perf Work stream for Metrics, Performance and Optimizer
Milestone

Comments

@schlessera
Copy link
Collaborator

schlessera commented Apr 21, 2020

While writing the documentation, I'm noticing some minor consistency issues that should be straightened out at the earliest possible convenience.

I'm collecting these here to make a grouped PR for this as a dependency for the docs PR.

  • The TransformationEngine's first argument Configuration $configuration should be made optional via a poka-yoke, just as the second argument is. This would then fall back to the default out-of-the-box configuration.

  • The required order of the arguments when a transformer implements both Configurable and MakesRemoteRequests should be swapped, so that it matches the order of the Configuration and RemoteGetRequest arguments in the TransformationEngine's constructor.

  • Docblocks in FilesystemRemoteGetRequest are copypasta from StubbedRemoteGetRequest and need to be adapted.

@schlessera schlessera self-assigned this Apr 21, 2020
@kmyram kmyram modified the milestones: v1.5.4, v1.6 May 27, 2020
@kmyram kmyram closed this as completed Jun 2, 2020
@westonruter westonruter modified the milestones: v1.6, v1.5.4 Jun 2, 2020
@kmyram kmyram assigned westonruter and unassigned schlessera Jun 16, 2020
@schlessera schlessera added the WS:Perf Work stream for Metrics, Performance and Optimizer label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Optimizer WS:Perf Work stream for Metrics, Performance and Optimizer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants