Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide width alignment of videopress block is not respected in AMP mode. #4692

Closed
deepaklalwani97 opened this issue May 13, 2020 · 1 comment · Fixed by #4693
Closed

Wide width alignment of videopress block is not respected in AMP mode. #4692

deepaklalwani97 opened this issue May 13, 2020 · 1 comment · Fixed by #4693
Assignees
Milestone

Comments

@deepaklalwani97
Copy link
Contributor

deepaklalwani97 commented May 13, 2020

Bug Description

The videopress block does not respect the wide width alignment in the AMP mode. This happens only with the videopress block because the videopress block uses the amp-iframe and the intrinsic layout for all alignments except for the full width alignment. The solution to this could be using the responsive layout for blocks with wide width alignment.

Expected Behaviour

The videopress block with wide width alignment should have a wide width in the AMP mode.

Steps to reproduce

  1. Create a videopress block from the Gutenberg editor and change alignment to wide width.
  2. Check the post in frontend with AMP mode the video does not respect the wide width alignment.

Screenshots

Wide width aligned Videopress block in Non AMP mode

image

Wide width aligned Videopress block in Non AMP mode

image

Additional context

  • WordPress version: 5.4.1
  • Plugin version: 1.5.3
  • AMP plugin template mode: Transitional

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@deepaklalwani97 deepaklalwani97 changed the title Wide width alignment of videopress block is not respected in amp mode. Wide width alignment of videopress block is not respected in AMP mode. May 13, 2020
@kmyram kmyram added this to the v1.5.4 milestone May 27, 2020
@kmyram kmyram closed this as completed Jun 2, 2020
@pierlon
Copy link
Contributor

pierlon commented Jun 17, 2020

QA Passed:

The embed is visually the same as the non-AMP counterpart and has the right layout applied when the "wide width" alignment is applied to the embed block:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants