Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post with Amazon Kindle block producing validation error #4758

Closed
itowhid06 opened this issue May 22, 2020 · 0 comments · Fixed by #4759
Closed

Post with Amazon Kindle block producing validation error #4758

itowhid06 opened this issue May 22, 2020 · 0 comments · Fixed by #4759
Assignees
Labels
Milestone

Comments

@itowhid06
Copy link
Contributor

Bug Description

In the WordPress Block Editor, if the Amazon Kindle block is added then a validation error occurs.

As there is a type="text/html" attribute-value combination present in the iframe generated from the Amazon Kindle embed and type is not a standard <iframe> attribute, that is why the validation error occurs. Though type is a non-standard attribute, it is fairly common in some embeds.

Expected Behaviour

Embeds with fairly common non-standard attributes like type should not produce validation errors.

Steps to reproduce

  1. Create a post with Amazon Kindle block.
  2. Validate the post.
  3. See the validation error in back-end.

Screenshots

Validation error with Amazon Kindle block

image

Additional context

  • WordPress version:
  • Plugin version:
  • Gutenberg plugin version (if applicable):
  • AMP plugin template mode:
  • PHP version:
  • OS:
  • Browser: [e.g. chrome, safari]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants