Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP list Initialization from amp-state issue #4870

Closed
kishanugc opened this issue Jun 16, 2020 · 3 comments
Closed

AMP list Initialization from amp-state issue #4870

kishanugc opened this issue Jun 16, 2020 · 3 comments
Labels
WS:Core Work stream for Plugin core
Milestone

Comments

@kishanugc
Copy link

kishanugc commented Jun 16, 2020

AMP list failed to Initialization from amp-state

We try many times using amp state but amp plugin removes amp list code or removes SRC attribute. We have bind amp list SRC using amp state value according to the amp. Please check the below Screenshot for more detail.
image

Right now, we have added an amp list example in the All Store page but amp plugin removes amp list. Please check the below URL & Screenshot for more detail.
URL : https://devlop.wpengine.com/all-stores/

image

AMP playground URL it’s working fine. Please check below AMP Playground Screenshot for more detail.

image

The below link is a content amp list code.
https://devlop.wpengine.com/code.txt

Please help me as soon as possible.

@westonruter
Copy link
Member

This was fixed in #4548 but it is not yet in a stable release. If you are currently developing your site and are comfortable using the 1.6-alpha version, then I recommend using the latest build from develop: https://github.com/ampproject/amp-wp/wiki/Development-Builds

Otherwise, we may cherry-pick the fix specifically for the upcoming 1.5.4 release.

@westonruter
Copy link
Member

I'll include this in a 1.5.x release.

@westonruter
Copy link
Member

PR #4992 merged into 1.5 branch. Build for testing available at #4992 (comment).

@kmyram kmyram added the WS:Core Work stream for Plugin core label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS:Core Work stream for Plugin core
Projects
None yet
Development

No branches or pull requests

3 participants