Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose loopback request test failure when "Failed to fetch URL to validate" #4978

Closed
westonruter opened this issue Jul 2, 2020 · 2 comments
Labels
Enhancement New feature or improvement of an existing one P2 Low priority Validation WS:Core Work stream for Plugin core

Comments

@westonruter
Copy link
Member

Feature description

As seen in this support topic, when a site is unable to perform loopback requests, this is not made immediately clear to the user. The error message does tell the user to verify the site can perform loopback requests:

image

But we could be something more proactive by actually invoking \WP_Site_Health::can_perform_loopback() (e.g. via Ajax) and tell them right there it is failing.

If the issue is indeed with loopback requests, then we should provide some more guidance about how to resolve the issue, not only for the AMP plugin to work properly but also for this critical health of a site.

This is related to #3789, which is to proactively warn when loopback requests are failing.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Enhancement New feature or improvement of an existing one P2 Low priority labels Jul 2, 2020
@westonruter westonruter added this to the v1.7 milestone Jul 2, 2020
@kmyram kmyram added the WS:Core Work stream for Plugin core label Aug 5, 2020
@westonruter westonruter modified the milestones: v2.1, v2.2 Apr 8, 2021
@westonruter
Copy link
Member Author

This will not be relevant if we move away from using loopback requests for user-initiated validation. See #4979.

Also, see #5099 for validation request checking to Site Health.

Related: #3789.

@westonruter westonruter removed this from the v2.2 milestone Jun 18, 2021
@westonruter
Copy link
Member Author

Closing this because we've not had many reports of this and we intend to move away from loopback requests for most validation checks. See #4979.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or improvement of an existing one P2 Low priority Validation WS:Core Work stream for Plugin core
Projects
None yet
Development

No branches or pull requests

3 participants