Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert YouTube shortcode and oEmbed to <amp-youtube> #5

Closed
mjangda opened this issue Sep 29, 2015 · 2 comments
Closed

Convert YouTube shortcode and oEmbed to <amp-youtube> #5

mjangda opened this issue Sep 29, 2015 · 2 comments
Labels
Enhancement New feature or improvement of an existing one
Milestone
v0.2

Comments

@mjangda
Copy link
Contributor

mjangda commented Sep 29, 2015

See https://github.com/ampproject/amphtml/blob/master/extensions/amp-youtube/amp-youtube.md
@mjangda mjangda added the Enhancement New feature or improvement of an existing one label Sep 29, 2015
@mjangda mjangda added this to the Developer Preview milestone Sep 29, 2015
@mjangda mjangda mentioned this issue Oct 20, 2015
Closed
@mjangda mjangda modified the milestones: Developer Preview, v1 Oct 30, 2015
@mjangda mjangda mentioned this issue Nov 8, 2015
Merged
@corysimmons
Copy link

When I replace the thumbnail with a featured video it puts the video on top of the entire webpage (immediately inside <body>) whereas with just the featured image it puts it at the top of the content appropriately (after the post's header).

https://github.com/Automattic/amp-wp/blob/master/readme.md#featured-image

Update: just ended up executing the youtube shortcode instead. :(

@mjangda
Copy link
Contributor Author

mjangda commented Mar 8, 2016

@corysimmons Can you share the code you were using?

@keltips keltips mentioned this issue May 10, 2018
Closed
@nickreale nickreale mentioned this issue May 19, 2018
Closed
@valtermild valtermild mentioned this issue Nov 10, 2018
Closed
4 tasks
@askmeoffers askmeoffers mentioned this issue Apr 3, 2020
Closed
@jwold jwold mentioned this issue Aug 25, 2021
Closed
@diabitogoaway diabitogoaway mentioned this issue Mar 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or improvement of an existing one
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
2 participants
@mjangda @corysimmons