Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all active plugins in Plugin Suppression rather than just those with validation errors detected #5126

Closed
westonruter opened this issue Jul 29, 2020 · 0 comments · Fixed by #5133
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. P0 High priority WS:Core Work stream for Plugin core
Milestone

Comments

@westonruter
Copy link
Member

Feature description

Currently the Plugin Suppression section only appears if there are active plugins which have validation errors currently detected (for non-stale validation results). This results in a section that appears and disappears seemingly at random. This can make it difficult for users who know up-front that they will want to suppress a given plugin, as they'll try to find a scenario to cause a validation error for that plugin to be triggered. This is complicated even more for users who don't have developer tools enabled, since at present validation results won't be stored for them (until #1756).

Additionally, the Plugin Suppression section being hidden when the plugin is first activated hurts discoverability for the feature.

So, the Plugin Suppression section should be always displayed and populated with all active plugins, not just the active plugins that have non-stale validation errors associated with them.

Something else to consider: we may want to add a “AMP Suppressed” column to the plugin list table which allows this suppression to be managed from the Plugins screen, in a similar way to how users can manage whether a plugin will auto-update in WordPress 5.5. This would allow for a user to install a plugin and suppress it from being active on AMP pages even before it is first activated. This could also make Plugin Suppression integrate more seamlessly with the rest of WordPress.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added this to the v2.0 milestone Jul 29, 2020
@westonruter westonruter self-assigned this Jul 29, 2020
@westonruter westonruter added the P0 High priority label Jul 30, 2020
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Aug 1, 2020
@kmyram kmyram added the WS:Core Work stream for Plugin core label Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. P0 High priority WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants