Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow amp-story-player #5205

Closed
fellyph opened this issue Aug 10, 2020 · 4 comments
Closed

allow amp-story-player #5205

fellyph opened this issue Aug 10, 2020 · 4 comments

Comments

@fellyph
Copy link
Collaborator

fellyph commented Aug 10, 2020

Bug Description

I'm testing the Web Stories plugin, I'm not sure if I should raise the issue here or at the Web Story repo but I'm getting a validation error DISALLOWED_TAG for amp-story-player when I add a web story on my posts.

Expected Behaviour

AMP story should be a valid tag?

Steps to reproduce

  1. Create a new web story
  2. Add a web story in a post
  3. Try to validate the post

Screenshots

Screen Shot 2020-08-10 at 08 51 53

Additional context

  • WordPress version: 5.4.2
  • Plugin version: 1.5.5
  • Gutenberg plugin version (if applicable):
  • AMP plugin template mode: Standard
  • PHP version: 7.3
  • OS: Mac
  • Browser: chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@schlessera
Copy link
Collaborator

Hey @fellyph !

Thanks for the bug report. This is a known issue and should be resolved in the latest v2.0 beta release. See #5075

@schlessera
Copy link
Collaborator

Fixed via #5075

@schlessera
Copy link
Collaborator

@fellyph If you want to test with the new beta, you can find the latest release here:
https://github.com/ampproject/amp-wp/releases/tag/2.0.0-beta3

@fellyph
Copy link
Collaborator Author

fellyph commented Aug 10, 2020

Hi @schlessera

I read the v2.0 milestone looks great I will test it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants