Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WP-CLI commands for managing AMP settings #5783

Closed
westonruter opened this issue Jan 17, 2021 · 3 comments · Fixed by #7430
Closed

Add WP-CLI commands for managing AMP settings #5783

westonruter opened this issue Jan 17, 2021 · 3 comments · Fixed by #7430
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one Groomed P1 Medium priority WP-CLI WS:Core Work stream for Plugin core
Milestone

Comments

@westonruter
Copy link
Member

Feature description

As demonstrated by #5782, there is a need for WP-CLI commands to manipulate the AMP settings, including:

I'm specifically not including the manipulation of Analytics here, as we want to discourage it from being used.

In addition to updating the settings, we also need to be able to query the existing settings.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@westonruter westonruter added Enhancement New feature or improvement of an existing one WP-CLI WS:Core Work stream for Plugin core labels Jan 17, 2021
@westonruter westonruter added this to the v2.2 milestone Feb 11, 2021
@kmyram kmyram added P1 Medium priority Groomed labels Feb 16, 2021
@westonruter westonruter added P2 Low priority and removed P1 Medium priority labels Jul 29, 2021
@westonruter westonruter modified the milestones: v2.2, v2.3 Nov 30, 2021
@westonruter westonruter modified the milestones: v2.3, v2.4 Dec 23, 2021
@westonruter westonruter removed this from the v2.4 milestone Apr 14, 2022
@westonruter westonruter added this to the v2.3.1 milestone Nov 30, 2022
@westonruter westonruter added P1 Medium priority and removed P2 Low priority labels Nov 30, 2022
@westonruter
Copy link
Member Author

@milindmore22 What settings are the most important to be included in the CLI interface? We won't likely need to include every possible setting (e.g. toggling specific templates). We should prioritize what will actually be useful (e.g. switching template mode).

@milindmore22
Copy link
Collaborator

I will suggest including the following which seems essential

  • Setting the template mode.
  • Setting the Reader theme.
  • Toggling mobile redirection.
  • Updating suppressed plugins.

Good to have but not essential

  • Updating the supported post types
  • Toggling whether all templates are supported, and otherwise toggling individual templates.

@pavanpatil1
Copy link

QA passed ✅

Cross-checked the issue, Verified the WP-CLI command added related to AMP settings those are working fine.

image

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one Groomed P1 Medium priority WP-CLI WS:Core Work stream for Plugin core
Projects
None yet
5 participants