-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the TikTok embed handler to use amp-tiktok
component
#6060
Comments
Looks like we're still waiting on ampproject/amphtml#32219 to be closed. The validator spec hasn't yet been updated. |
This can now be worked on as a PR off of #6436. |
The PR has been merged into |
(To re-check on 2.1.4) |
I've fixed the 2.1 build errors via #6574. That should allow a new 2.1 branch build to be created, although there is a JS unit test error still. See #6235 (comment). |
Feature description
Now that ampproject/amphtml#32651 has been merged we can begin the process of updating
AMP_TikTok_Embed_Handler
to use theamp-tiktok
component instead ofamp-embedly-card
.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
amp-tiktok
component being used on the AMP page.Implementation brief
AMP_TikTok_Embed_Handler
to use theamp-tiktok
component rather than theamp-embedly-card
one.QA testing instructions
Demo
Changelog entry
The text was updated successfully, but these errors were encountered: