Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Expanded menu not Working on the Twenty Twenty Theme #7056

Closed
fellyph opened this issue Apr 14, 2022 · 5 comments · Fixed by #7094
Closed

Desktop Expanded menu not Working on the Twenty Twenty Theme #7056

fellyph opened this issue Apr 14, 2022 · 5 comments · Fixed by #7094
Assignees
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Milestone

Comments

@fellyph
Copy link
Collaborator

fellyph commented Apr 14, 2022

Bug Description

The core theme Twenty Twenty, has different Menu Locations and one option is the Desktop Expended Menu:

Screen Shot 2022-04-14 at 16 17 42

When this option is selected only appears in the non-AMP version:

non-AMP version:
Screen Shot 2022-04-14 at 16 16 23

AMP version:
Screen Shot 2022-04-14 at 16 21 49

Expected Behaviour

The AMP version should display the expanded menu option as the non-AMP version

Screenshots

No response

PHP Version

8.0

Plugin Version

2.2.4

AMP plugin template mode

Standard, Transitional

WordPress Version

5.9.3

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@fellyph fellyph added the Bug Something isn't working label Apr 14, 2022
@westonruter
Copy link
Member

What is the “AMP sidebar menu” theme location there? Where is that coming from?

@westonruter
Copy link
Member

We should check to see if this is a recent regression.

@fellyph
Copy link
Collaborator Author

fellyph commented Apr 14, 2022

The "AMP Sidebar menu" is from the James's sidebar menu plugin

@westonruter westonruter added this to the v2.3 milestone Apr 14, 2022
@dhaval-parekh dhaval-parekh self-assigned this May 5, 2022
@dhaval-parekh
Copy link
Collaborator

After checking with a different version found that this bug introduces in AMP version 2.2.2 ( because of this change )

Before the change it was converting .no-js .hide-no-js selector into :root:not(#_):not(#_):not(#_):not(#_):not(#_):not(#_):not(#_) .no-js .hide-no-js which was not applying to expanded menu in twenty-twenty theme, But after changes it convert into .no-js .hide-no-js:not(#_#_#_#_#_#_#_) which is apply to expanded menu. ( Note: menu have header-toggles hide-no-js classes )

@pooja-muchandikar
Copy link

QA Passed ✅

Cross checked the issue with the test environment mentioned in the issue description and the fix added to the issue is working as expected.

Screen.Recording.2022-06-06.at.8.39.24.PM.mov

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants