Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate googleanalytics (UA) vendor type in favor of gtag (GA4) #7567

Closed
westonruter opened this issue Jun 29, 2023 · 2 comments · Fixed by #7580
Closed

Deprecate googleanalytics (UA) vendor type in favor of gtag (GA4) #7567

westonruter opened this issue Jun 29, 2023 · 2 comments · Fixed by #7580
Assignees
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Milestone

Comments

@westonruter
Copy link
Member

Feature Description

As is well known, the universal analytics (UA) version of Google Analytics is being sunset imminently in favor of GA4. Support for GA4 in AMP just landed: ampproject/amphtml#24621 (comment)

The GA4 configuration uses the gtag vendor type as opposed to googleanalytics. Therefore:

  1. The entry label for "Google Analytics" should be updated to say "Google Analytics (Deprecated)" in:

'value' => 'googleanalytics',
'label' => 'Google Analytics',

Note that the vendor entry on AMP.dev will be updated accordingly.

  1. There is a notice currently displayed when the user has selected googleanalytics to consider using Site Kit instead (which will support GA4 shortly per AMP: Add support for tagging with GA4 google/site-kit-wp#7221). However, the notice should be updated to be a warning here, perhaps by adding this sentence to the end of the paragraph:

Nevertheless, the googleanalytics type is obsolete as Google Analytics has switched to use gtag in the transition from Universal Analytics (UA) to GA4. Please use gtag instead. Learn more about GA4 in AMP.

image

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Jun 29, 2023
@westonruter westonruter added this to the v2.4.2 milestone Jun 29, 2023
@thyngster
Copy link

Universal Analytics will kept working for 360 users for 1 more year. Not having it available freely for everyone may not be a synonim for "deprecated", maybe "legacy" is a better tag until it gets really deprecated...

@thelovekesh thelovekesh self-assigned this Jul 10, 2023
@thelovekesh thelovekesh added Bug Something isn't working P2 Low priority Reader Mode WS:Core Work stream for Plugin core and removed Bug Something isn't working P2 Low priority Reader Mode WS:Core Work stream for Plugin core labels Jul 13, 2023
@pooja-muchandikar
Copy link

QA Passed ✅

Before Fix:

image


After Fix:

image (3)

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants