Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node to 16 or 18 #7599

Closed
westonruter opened this issue Aug 16, 2023 · 2 comments · Fixed by #7605
Closed

Update node to 16 or 18 #7599

westonruter opened this issue Aug 16, 2023 · 2 comments · Fixed by #7605
Assignees
@thelovekesh
Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Milestone
v2.5.0

Comments

@westonruter
Copy link
Member

Feature Description

Now that Gutenberg and WordPress core have been updated to node 16, we can do the same (perhaps even node 18).

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response
@westonruter westonruter added the Enhancement New feature or improvement of an existing one label Aug 16, 2023
@westonruter westonruter added this to the v2.4.3 milestone Aug 16, 2023
@westonruter
Copy link
Member Author

Blocked by Gutenberg 16.5 release, due out on August 23rd.

@thelovekesh thelovekesh mentioned this issue Sep 1, 2023
Merged
2 tasks
@pavanpatil1
Copy link

QA Passed ✅

All workflows are running with the node v18 and the plugin build is passing and working fine.

image

image

@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Nov 6, 2023
@github-project-automation github-project-automation bot moved this to QA Passed in Ongoing Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thelovekesh thelovekesh

Labels
Changelogged Whether the issue/PR has been added to release notes. Enhancement New feature or improvement of an existing one
Projects
Ongoing
Archived in project
Milestone
v2.5.0
Development

Successfully merging a pull request may close this issue.

Bump NodeJS from 14 to 18 ampproject/amp-wp
3 participants
@westonruter @pavanpatil1 @thelovekesh