Incorrect use of $query->get_posts(), resulting in double request processing

[OlaIola]

Bug Description

The WP_Query() constructor calls $this->get_posts() inside __constructor() and it is the longest method in the class and the next time it is called it does not return the result but rebuilds the entire query. The plugin uses this methog in 5 places.

Expected Behaviour

The same as before but avoiding unnecessary data processing and requests.

Screenshots

No response

PHP Version

No response

Plugin Version

2.5.3

AMP plugin template mode

Standard

WordPress Version

6.5

Site Health

No response

Gutenberg Version

No response

OS(s) Affected

No response

Browser(s) Affected

No response

Device(s) Affected

No response

Acceptance Criteria

No response

Implementation Brief

No response

QA Testing Instructions

No response

Demo

No response

Changelog Entry

No response

[westonruter]

@OlaIola Hi! So you're saying that anywhere that we're calling $query->get_posts() we should replace with $query->posts?

[OlaIola]

Hi @westonruter 👋🏻
We should use getters if possible, but in this case it is not working as expected, and $posts property is public, so $query->posts is fine and will be a minimal change. Or it can be:

$query = new WP_Query(); 
$found_posts = $query->query( $args );

[westonruter]

I've opened #7782 to fix this.

@OlaIola How did you discover this issue?

[OlaIola]

I discovered this issue at my own code with Query Monitor, it indicated that I am making some requests twice. Data can be served from the cache object the second time, but WP_Query is still processing the request. Query Monitor is not working with feeds, but I went to look in the site code base for this issue in general.

[thelovekesh]

QA Passed ✅

See #7782 (comment)