Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wordpress.com AMP version doesn't support Gist embeds #879

Closed
mehigh opened this issue Jan 18, 2018 · 2 comments
Closed

The wordpress.com AMP version doesn't support Gist embeds #879

mehigh opened this issue Jan 18, 2018 · 2 comments

Comments

@mehigh
Copy link
Contributor

mehigh commented Jan 18, 2018

We should check the final version would have support for Github GIst them, as they're text-only.

needs-testing

@westonruter
Copy link
Member

See list of core embeds being targeted here: #806 (comment)

Support for oEmbeds Gists are added by Jetpack: https://github.com/Automattic/jetpack/blob/b4ee9f55cb3819ffb4ce519c668130282e1a3544/modules/shortcodes/gist.php#L9-L10

There is an amp-gist component which can be used here.

The best move here would probably to open a PR to Jetpack to add a new AMP_Base_Embed_Handler subclass for AMP_Gist_Embed_Handler which can do similarly to what can be seen in the Tweet embed support: https://github.com/Automattic/amp-wp/blob/develop/includes/embeds/class-amp-twitter-embed.php

@westonruter
Copy link
Member

Closing as duplicate of #375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants