Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Update Analytics Tracking Invironment #98

Open
dakkad opened this issue Jan 8, 2019 · 3 comments
Open

Update Analytics Tracking Invironment #98

dakkad opened this issue Jan 8, 2019 · 3 comments
Assignees

Comments

@dakkad
Copy link
Contributor

dakkad commented Jan 8, 2019

Update production environment to include Google Analytics property tracking ID: UA-124404404-1

@ithinkihaveacat
Copy link
Collaborator

That ID does seem to be the default, however it's not being output on https://ampbench.appspot.com/--perhaps because the GTAG_ID environment variable is not been defined in that environment?

@pietergreyling How is this supposed to work in production? Should the GTAG_ID be configured in app.yaml? (I'm not sure how this ever worked!)

@pietergreyling
Copy link
Contributor

@ithinkihaveacat Yes, this issue is to have tracking ID implemented in the environment as per here:
https://cloud.google.com/appengine/docs/flexible/nodejs/integrating-with-analytics

@pietergreyling
Copy link
Contributor

pietergreyling commented Jan 13, 2019

@ithinkihaveacat
I am not sure that building Google Analytics into an open source project like AMPBench is appropriate (?)

Out if principle I have opened an issue to have the GA code removed:
#100

However, I think we should all discuss this and agree on the best way forward.

@pietergreyling pietergreyling self-assigned this Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants