-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: remove sidebar children and width restrictions #10587
Comments
Related #6452 |
Notes from design review: sounds good! (also want to review sidebar 1.0 details and other options with @dvoytenko and @pbakaus) |
This issue hasn't been updated in awhile. @ericlindley-g Do you have any updates? |
Done: /to @camelburrito Double-checking: are the following two also done?
|
no :( |
This issue hasn't been updated in awhile. @camelburrito Do you have any updates? |
This issue hasn't been updated in awhile. @aghassemi Do you have any updates? |
Context:
amp-sidebar currently disallows a broad set of children, including amp-iframe, and enforces a max-width relative to the viewport width
Initially these restrictions were in place to discourage bad UX: i.e. blocking ads, getting trapped in the sidebar with no close affordance, etc
However, the risk of supporting these experiences through sidebar is low, given the restriction that the sidebar can't be open on page load, and given that amp-bind, amp-selector, and the universal "show" action all support the same UX (albeit with slightly higher friction to do).
I propose we lift both the content and width restrictions entirely. Will bring to design review to discuss.
The text was updated successfully, but these errors were encountered: