Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: remove sidebar children and width restrictions #10587

Closed
ericlindley-g opened this issue Jul 23, 2017 · 7 comments
Closed

FR: remove sidebar children and width restrictions #10587

ericlindley-g opened this issue Jul 23, 2017 · 7 comments

Comments

@ericlindley-g
Copy link
Contributor

Context:
amp-sidebar currently disallows a broad set of children, including amp-iframe, and enforces a max-width relative to the viewport width

Initially these restrictions were in place to discourage bad UX: i.e. blocking ads, getting trapped in the sidebar with no close affordance, etc

However, the risk of supporting these experiences through sidebar is low, given the restriction that the sidebar can't be open on page load, and given that amp-bind, amp-selector, and the universal "show" action all support the same UX (albeit with slightly higher friction to do).

I propose we lift both the content and width restrictions entirely. Will bring to design review to discuss.

@aghassemi
Copy link
Contributor

Related #6452

@ericlindley-g
Copy link
Contributor Author

Notes from design review: sounds good!
Also remove !important for background scrim, and make sure that having two sidebars is OK

(also want to review sidebar 1.0 details and other options with @dvoytenko and @pbakaus)
/cc @camelburrito @torch2424

@ericlindley-g ericlindley-g modified the milestones: New FRs, Pending Triage Jul 26, 2017
@ericlindley-g ericlindley-g changed the title For discussion (design review): remove sidebar children and width restrictions FR: remove sidebar children and width restrictions Jul 26, 2017
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @ericlindley-g Do you have any updates?

@ericlindley-g
Copy link
Contributor Author

Done:
√ 2 sidebars on a page
√ broader set of children allowed

/to @camelburrito

Double-checking: are the following two also done?

  • Removing max-width 80vw restriction
  • Allow removing background scrim

@camelburrito
Copy link
Contributor

no :(

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @camelburrito Do you have any updates?

@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @aghassemi Do you have any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants