Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-mustache removes application/json script tags #12023

Closed
aghassemi opened this issue Nov 11, 2017 · 6 comments
Closed

amp-mustache removes application/json script tags #12023

aghassemi opened this issue Nov 11, 2017 · 6 comments

Comments

@aghassemi
Copy link
Contributor

aghassemi commented Nov 11, 2017

Template sanitizer currently removes <script type="application/json"> which means that components that rely on JSON configurations (amp-animation, amp-ima-video) can not be be used inside amp-list

/cc @dvoytenko @choumx

@jc275
Copy link

jc275 commented Dec 7, 2017

Same applies to <script type="application/ld+json"> tags, which would presumably be useful for marking up amp-list items.

@zhouyx
Copy link
Contributor

zhouyx commented Jan 10, 2018

Same with <amp-analytics>

@aghassemi
Copy link
Contributor Author

/cc @choumx @danielrozenberg if case you are interested as you have been improving the sanitizer recently.

@lannka
Copy link
Contributor

lannka commented Feb 6, 2018

@Gregable and I are working on a new templating language designed with AMP validator in consideration. Details are coming soon.

We might deprioritize this work and recommend users to move towards the new templating language once built.

@src-code
Copy link
Contributor

src-code commented Mar 15, 2018

Adding my voice of support for prioritizing a fix for this, or that new templating language, sooner rather than later. We (Oath/Yahoo) have a use case where we need to beacon viewability on elements rendered by an amp-list, including beacon data returned in the amp-list response, and it seems to be impossible to do currently without either a) amp-analytics processing async content for trigger elements, allowing them to be tracked directly and thus allow use of data attributes for analytics vars, or b) amp-list allowing us to embed additional amp-analytics config/vars in the response. Using external config for amp-analytics to work around this issue is not realistic for us since the data we need for the beacons is dynamic and unique to each amp-list response.

@aghassemi aghassemi assigned dreamofabear and unassigned aghassemi Mar 15, 2018
@aghassemi
Copy link
Contributor Author

assigning to @choumx for prioritization in runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants