Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-carousel does not seem to work fine with amp-video #1293

Closed
pmlopes opened this issue Jan 5, 2016 · 5 comments · Fixed by #2123
Closed

amp-carousel does not seem to work fine with amp-video #1293

pmlopes opened this issue Jan 5, 2016 · 5 comments · Fixed by #2123
Assignees
Milestone

Comments

@pmlopes
Copy link

pmlopes commented Jan 5, 2016

I was trying to make a carousel with a mix of photos and videos (like a photo gallery) and i noticed the following:

Once me as a user starts playing the video the carousel navigation buttons dissapear and i can't navigate out of it (either left or right).

If i do not enable the responsive layout of the video and it fits in the carousel (because the video is smaller than my screen) then i can use the carousel buttons to navigate left/right BUT the video keeps playing in the background.

Is this possible? have a carousel with video (mp4) not 3rd party providers like youtube/vine/etc...?

@dvoytenko
Copy link
Contributor

@pmlopes you are using type=slides carousel, right?

@erwinmombay Seems very strange, why would arrows disappear? And we should definitely stop video from playing as soon as it's out of the view.

@pmlopes
Copy link
Author

pmlopes commented Jan 5, 2016

This was my experiment: https://gist.github.com/pmlopes/59540785ac82410c80d6

Basically i started stripping the full example to just have a carousel with both pictures and videos

@pmlopes
Copy link
Author

pmlopes commented Jan 5, 2016

to see the arrows dissapear you need to use amp-video with layout responsive layout="responsive"

@erwinmombay
Copy link
Member

thanks @pmlopes ! looking into this

@erwinmombay
Copy link
Member

"If i do not enable the responsive layout of the video and it fits in the carousel (because the video is smaller than my screen) then i can use the carousel buttons to navigate left/right BUT the video keeps playing in the background." -- this is definitely a bug.

@pmlopes can you clarify this a bit more "Once me as a user starts playing the video the carousel navigation buttons dissapear and i can't navigate out of it (either left or right)."

  • can you provide a screenshot of this scenario (if possible)
  • does it look like this? (below)

screen shot 2016-01-07 at 3 37 12 pm

wherein you click play, the controls fade away and the "next" button appears. The next button appearing is a bug, but the controls fading away is intentional (shows again on tap, or hover on desktop)

@rudygalfi rudygalfi modified the milestones: M1, Feb 13 Feb 4, 2016
@rudygalfi rudygalfi modified the milestones: Feb 12, Feb 19 Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants