-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-carousel does not seem to work fine with amp-video #1293
Comments
@pmlopes you are using @erwinmombay Seems very strange, why would arrows disappear? And we should definitely stop video from playing as soon as it's out of the view. |
This was my experiment: https://gist.github.com/pmlopes/59540785ac82410c80d6 Basically i started stripping the full example to just have a carousel with both pictures and videos |
to see the arrows dissapear you need to use amp-video with layout responsive |
thanks @pmlopes ! looking into this |
"If i do not enable the responsive layout of the video and it fits in the carousel (because the video is smaller than my screen) then i can use the carousel buttons to navigate left/right BUT the video keeps playing in the background." -- this is definitely a bug. @pmlopes can you clarify this a bit more "Once me as a user starts playing the video the carousel navigation buttons dissapear and i can't navigate out of it (either left or right)."
wherein you click play, the controls fade away and the "next" button appears. The next button appearing is a bug, but the controls fading away is intentional (shows again on tap, or hover on desktop) |
I was trying to make a carousel with a mix of photos and videos (like a photo gallery) and i noticed the following:
Once me as a user starts playing the video the carousel navigation buttons dissapear and i can't navigate out of it (either left or right).
If i do not enable the responsive layout of the video and it fits in the carousel (because the video is smaller than my screen) then i can use the carousel buttons to navigate left/right BUT the video keeps playing in the background.
Is this possible? have a carousel with video (mp4) not 3rd party providers like youtube/vine/etc...?
The text was updated successfully, but these errors were encountered: