amp-next-page: Image URLs aren't rewritten from canonical to cache

[peterjosling]

What's the issue?

amp-next-page uses canonical URLs for images in the recommendation box when being served from the cache. It should be transforming them to cache URLs a la amp-img

[peterjosling]

Can you please reopen this? #15699 is a separate issue (the document URLs weren't getting rewritten properly), this is just to note that the image URLs are always going to point to the canonical source, and need rewriting separately.

[aghassemi]

@peterjosling Got it.

This would require AMP Cache to understand the JSON data and do replacement on it during ingestion. /cc @Gregable

and if we ever allow publishers to use an endpoint for JSON data instead of inlining it, we won't be able to do it anymore for remote src cases.

[aghassemi]

One possible approach to this with does not require cache changes is forcing authors to put the images in the page using amp-img id=foo1 layout=nodisplay and then just point to the id in their JSON instead of Url.

This approach would allow use of srcset as well which currently is not supported.

[ampprojectbot]

This issue seems to be in Pending Triage for awhile. @peterjosling Please triage this to an appropriate milestone.

[ampprojectbot]

This issue seems to be in Pending Triage for awhile. @peterjosling Please triage this to an appropriate milestone.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.