-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow amp-ad and amp-analytics to be rendered in amp-next-page articles. #15807
Comments
/to @peterbaran @emarchiori |
Looks like @peterjosling disabled this intentionally: https://github.com/ampproject/amphtml/blob/master/extensions/amp-next-page/0.1/next-page-service.js#L186 |
Thanks for trying out this feature, this feedback is very valuable. amp-ads not loading is not intentional, we will look into that. Do you have any more information about this? analytics in the loaded documents is disabled per design, as agreed with amp-analytics, as the configuration of the original document still applies inside loaded documents. Two things about this:
|
Fair enough. We have fallen back to amp-pixels for tracking the next page for now. One thing to keep in mind is the analytics config needs to be flexible enough to handle dynamic next page selection. So as long as the content of the next page can include the new analytics config, that's fine, though that seems like a complicated ask when you have 3 or 4 different analytics vendors on a page. All of them will need to be dynamically updated. We'll take a look at amp-next-page-scroll to see if that will help. |
That is good feedback. We are planning on interating a bit on the analytics behavior. What about amp-ads? Because in your example the second page does not have amp-ad tags, so I cannot test it, and it was working in other examples. Do you have a page were I can test this? |
Ads appear to be working now. Start here: https://www.popsugar.com/travel/Bermuda-Travel-Planning-2018-44817394/amp and scroll down to the next-page. |
@mpatnode Thanks for verifying. |
Closing issue as fixed. |
actually reopening re: Analytics part :D sorry |
cc/ @jeffjose |
+1 for this issue. The same can be replicated @ https://m.timesofindia.com/business/india-business/wipro-pays-75m-to-us-energy-utility-to-settle-suit/amp_articleshow/65285460.cms Attaching a screenshot of the same |
Have been following this thread for a while. Just noticed since yesterday page view analytics code has started to fire on amp-next-page. Is that working for others as well? |
Really? What are the semantics? Is it considered a whole new page? (that would be our preference). We took them all out and used pixels instead. |
This was unintentional - we still have work to do to work out what the semantics should be and to make sure we don't have duplicate triggers firing for scrolls etc. The previous functionality will be restored by #18026 |
Are you able to get the events using pixels? Unfortunately for us, it doesnt get triggered. Also, as mentioned above, GA triggers have stopped working for now. |
Well that was a terrifying moment. The pixels still work fine for us. Feel free to test this link: https://www.google.com/amp/s/www.popsugar.com/celebrity/Jennifer-Garner-Dating-Again-After-Divorce-From-Ben-Affleck-45362924/amp |
@mpatnode how you did to handle with the pixel? I was trying to implement the pixel as a workaround, but I couldn't see new pageviews. |
Nothing too magical. I'm still seeing the pixels fire on the page above, even when served from the CDN. Note that the Chrome Debug tools network search seems a little buggy in that they didn't always show up when I searched by hostname:
I do see we don't fire a GA pixel there, but we do Adobe, Comscore and our local counter. We should probably add GA. |
I am facing issue in amp-analytics for amp-next page as Client ID is dynamically change for same client. But this issue is coming if i navigate the page throgh google index like through below url https://www.google.com/amp/s/m.jagran.com/v/s/m.jagran.com/lite/technology/tech-news-jagran-hitech-awards-2019-smartphone-innovation-of-the-year-nominees-vivo-samsung-oppo-oneplus-19782556.html%3famp_js_v=0.1&usqp=mq331AQCKAE%253D#ampf= |
What's the issue?
We wanted to give our users an infinite scroll type experience and amp-next-page component is exactly what we were looking for. When we implemented it, we saw that the posts that we intended to include were not able to show
amp-ad
content oramp-analytics
content. On the other hand,amp-pixel
worked perfectly. So we wanted to request for allowingamp-analytics
andamp-ad
components to be allowed to be rendered inamp-next-page
components.How do we reproduce the issue?
If this is a bug please provide a public URL and ideally a reduced test case (e.g. on jsbin.com) that exhibits only your issue and nothing else. Then provide step-by-step instructions for reproducing the issue:
amp/amp-next-content
GET request as you reach closer the bottom of the post.Here is screenshot of the components loading in the main article:
Here is the
amp-next-page
framed article that loads almost the same template but the amp-analytics content is not rendered.What browsers are affected?
All browsers
Which AMP version is affected?
This is like bug, but since the
amp-next-page
component is in experimental stage, this could be considered as a feature request.amp-next-page: https://github.com/ampproject/amphtml/tree/master/extensions/amp-next-page
The text was updated successfully, but these errors were encountered: