Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator reports as error the '_self' value of 'target' attribute #1703

Closed
hugronaphor opened this issue Feb 1, 2016 · 2 comments
Closed

Comments

@hugronaphor
Copy link

The error:
The attribute 'target' in tag 'a' is set to the invalid value '_self'.

The markup:
<a href="http://www.theweek.co.uk/election-2015" target="_self">UK general election</a>

This attribute value should be allowed even if this is a defualt value for 'target' attribute.

@cramforce
Copy link
Member

The issue is that _self may be wrong in some embedding scenarios. This is why AMP pages should never rely on the default actually meaning _self. Allowing it would mean that embedders would have to explicitly do something else than the page is stating, which seems problematic.

@hugronaphor
Copy link
Author

Ok, in this case we really need to push on Issue #994 as it's hard to validate the markup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants