Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator overly sensitive to whitespace in rel attributes #18059

Closed
Gregable opened this issue Sep 14, 2018 · 1 comment
Closed

Validator overly sensitive to whitespace in rel attributes #18059

Gregable opened this issue Sep 14, 2018 · 1 comment
Assignees
@twifkak
Labels
P3: When Possible Type: Bug Validator: Type: Error Messages Issue with the quality of the error messages that the validator produces WG: caching
Milestone
Backlog Bugs

Comments

@Gregable
Copy link
Member

Gregable commented Sep 14, 2018 •
edited
Loading

Follow up from #18030, the AMP validator considers:

<a rel="attachment noopener noreferrer">

Valid, but considers:

<a rel="attachment noopener noreferrer">

Invalid. The difference, which isn't visible in markdown AFAICT, is multiple spaces between attachment and noopener.

This isn't a big deal, but does seem surprising and hard to debug for a publisher.
@Gregable Gregable self-assigned this Sep 14, 2018
@Gregable Gregable added this to the Backlog Bugs milestone Sep 14, 2018
@Gregable Gregable mentioned this issue Sep 14, 2018
Closed
@Gregable Gregable added WG: caching Validator: Type: Error Messages Issue with the quality of the error messages that the validator produces labels Jun 24, 2019
@Gregable Gregable removed their assignment Aug 5, 2019
@twifkak twifkak self-assigned this Aug 7, 2019
@Gregable Gregable closed this as completed Aug 8, 2019
@twifkak
Copy link
Member

twifkak commented Aug 8, 2019

(fixed by d97c0d9 of #23802)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twifkak twifkak

Labels
P3: When Possible Type: Bug Validator: Type: Error Messages Issue with the quality of the error messages that the validator produces WG: caching
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
4 participants
@twifkak @Gregable @dreamofabear @ampprojectbot