Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RRule support for amp-date-picker #25244

Closed
caroqliu opened this issue Oct 24, 2019 · 2 comments
Closed

Add RRule support for amp-date-picker #25244

caroqliu opened this issue Oct 24, 2019 · 2 comments
Assignees
@caroqliu
Labels
Component: amp-date-picker Customer: Developer P1: High Priority Type: Bug Type: DevX issues impacting developer experience WG: components

Comments

@caroqliu
Copy link
Contributor

Support was removed in #25230 and can be restored by reverting that change and importing RRule.

cc/ @ampproject/wg-ui-and-a11y @nainar
@caroqliu caroqliu self-assigned this Oct 24, 2019
@jridgewell jridgewell mentioned this issue Oct 29, 2019
Closed
@rsimha
Copy link
Contributor

rsimha commented Nov 13, 2019

If you run into type check errors while fixing this issue, see this list of past efforts to correctly import rrulestr for use in extensions/amp-date-picker/0.1/dates-list.js. It could be that the latest version of rrule doesn't have the same problems. Or maybe you'll find examples of how not to do it :)

@samouri samouri mentioned this issue Jun 15, 2020
Merged
@samouri
Copy link
Member

samouri commented Jul 1, 2020

Fixed in #28887

@samouri samouri closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caroqliu caroqliu

Labels
Component: amp-date-picker Customer: Developer P1: High Priority Type: Bug Type: DevX issues impacting developer experience WG: components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samouri @nainar @caroqliu @rsimha