Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource scheduling with IntersectionObserver #25428

Closed
dreamofabear opened this issue Nov 5, 2019 · 2 comments · Fixed by #29733
Closed

Resource scheduling with IntersectionObserver #25428

dreamofabear opened this issue Nov 5, 2019 · 2 comments · Fixed by #29733
Assignees
@dreamofabear
Labels
P1: High Priority Type: Feature Request WG: runtime

Comments

@dreamofabear
Copy link

Investigate replacing AMP's scroll-event-based resource scheduling system with IntersectionObserver.

Related: w3c/IntersectionObserver#372

New flagged feature in Chromium that enables rootMargin on implicit root in x-origin iframes: w3c/IntersectionObserver#372 (comment)
@dreamofabear dreamofabear self-assigned this Nov 5, 2019
@dreamofabear dreamofabear mentioned this issue Nov 11, 2019
Closed
@dreamofabear dreamofabear mentioned this issue Jan 7, 2020
Merged
@dreamofabear
Copy link
Author

Dima's suggestions on the "position" vs. "size" coupling issue:

InOb would legitimately skip most of resize events if they do not change intersection. I think this issue comes up here because we've been using measure(), requestMeasure(), mutateElement() and the rest of our infra to do all three: resize, position, and in-viewport monitoring. Separating them at this point would be difficult.

Alternative approach could be do something like this:

  1. Separate layoutBox into position and size.
  2. Remove calls to getLayoutBox() API and instead use an asynchronous API of some kind to either provide measurements or intersection.
  3. Remove measureCallback() APIs and replace them with async versions, that are cleaner map to resize observer concept.
  4. Remove inViewport() callback and replace with async API better mapped to InOb.

@dreamofabear dreamofabear mentioned this issue Mar 10, 2020
Closed
@dreamofabear dreamofabear mentioned this issue Mar 30, 2020
Merged
This was referenced Apr 8, 2020
Merged
Merged
Merged
Merged
Merged
Merged
@dreamofabear dreamofabear mentioned this issue Apr 27, 2020
Closed
@dreamofabear dreamofabear mentioned this issue May 16, 2020
Merged
This was referenced Jun 6, 2020
Merged
Merged
This was referenced Jun 25, 2020
Merged
Merged
@dreamofabear dreamofabear mentioned this issue Jul 9, 2020
Merged
@dreamofabear dreamofabear mentioned this issue Jul 17, 2020
Merged
@dreamofabear dreamofabear mentioned this issue Jul 30, 2020
Merged
@dreamofabear dreamofabear mentioned this issue Aug 7, 2020
Merged
@samouri
Copy link
Member

samouri commented Aug 7, 2020

🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamofabear dreamofabear

Labels
P1: High Priority Type: Feature Request WG: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ramp "intersect-resources" to 100% (third try) dreamofabear/amphtml
2 participants
@samouri @dreamofabear