Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic adoption of shadow mode #25630

Closed
2 of 3 tasks
wassgha opened this issue Nov 17, 2019 · 0 comments · Fixed by #25629 or #27035
Closed
2 of 3 tasks

Dynamic adoption of shadow mode #25630

wassgha opened this issue Nov 17, 2019 · 0 comments · Fixed by #25629 or #27035

Comments

@wassgha
Copy link
Contributor

wassgha commented Nov 17, 2019

Related to #22357 (part of #25500)

In order to offload code from extensions that use the MultiDocManager internally, one approach would be to allow adoption of shadow mode when such extensions are encountered which would expose the same API from PWAs to the extensions.

Implications

  • The extensions would now be able to use AMP.attachShadowDoc from the global object as opposed to having to create their own instance of MultiDocManager).

Tasks

  • Separate the overlaid shadow mode layer code from amp-shadow
  • Detect extensions that require shadow mode and dynamically adopt it before loading the extensions
  • Unit testing & e2e testing if needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants