-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrollbar not allowed on amp-access login link #2848
Comments
@hkmaly Absolutely. Will implement ASAP. |
@hkmaly while I'm fixing this... Could you actually clarify which browsers actually default |
"Default" is hard to pinpoint here. Firefox (and Palemoon) have a setting - dom.disable_window_open_feature.scrollbars - which have two values: false - honor the standard and true - force scrollbars to yes. See https://developer.mozilla.org/en-US/docs/Web/API/Window/open Firefox won't change the settings by itself on upgrade, but I suspect new installs set it to true. Or you may have it set that way manually. That's not something I would want to rely on. |
(Although I suppose people like me who didn't reset their profile since Firefox version 3 are rare, I have no idea when this might've changed.) |
I understand that it's supposed to work on smartphones and generally be small, but would it be possible to allow scrollbars on the login window? Currently, it's opened with window.open without scrollbars being mentioned, which unfortunately means they are turned off on some browsers. When the page content is bigger than the window, it's not possible to see it then.
How do we reproduce the issue?
https://www.einpresswire.com/amp/article/319717314/foam-for-wound-dressing-industry-by-companies-country-and-type-2016-to-2021-global-and-chinese-market-research-report
https://cdn.ampproject.org/c/s/www.einpresswire.com/amp/article/319962384/london-app-company-launches-a-new-scheme-making-social-apps-accessible-for-start-ups
What browsers are affected?
Palemoon and Firefox at least.
It seems working on chrominum and android chrome.
Which AMP version is affected?
Is this a new issue? Or was it always broken? Paste your AMP version. You can find it in the browser dev tools.
You mean the "Powered by AMP ⚡ HTML – Version 1459447315826" line? I never saw it work, but I'm only working on AMP for few weeks.
The text was updated successfully, but these errors were encountered: