🚨 Error: null is not an object (evaluating 'a.jsonTargeting.targeting')

[ampprojectbot]

Details

Error report: link
First seen: Jun 3, 2020
Frequency: ~ 447/day

Stacktrace

Error: null is not an object (evaluating 'a.jsonTargeting.targeting')
    at extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:898:46
    at rtcResponse (extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:885:30)
    at mergeRtcResponses_ (extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:759:6)

Notes

@rsimha modified extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:895-900 in #21212 (May 16, 2019)
@renovate-bot modified extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:885-885 in #27350 (Mar 30, 2020)
@calebcordry modified extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js:757-775 in #28575 (May 28, 2020)

Seen in:

• 06-05 Nightly (0512)
• 06-05 Nightly (2322)

Possible assignees: @calebcordry

/cc @ampproject/release-on-duty

[erwinmombay]

@calebcordry could you take a look at this?

[calebcordry]

yep will look, thanks for letting me know.

[rcebulko]

Side note: this is occurring ~450/day in Nightly, which would equate to around 45k/day if it reaches production (which would put it in the top 10). Logs indicate the error occurs on iPhones/iOS 13

[rcebulko]

Thanks for taking care of this so quickly! Great to see issues like this caught and fixed before reaching Beta. @calebcordry Should this be cherry-picked into the upcoming Beta/Experimental release?

[calebcordry]

Agree the nightly reporting is great! This doesn't actually break anything so if we are ok with the error spike I think its fine to follow the normal release process. WDYT?

[rcebulko]

If there's no impact to users it should be fine 👍