-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-iframe resize not working #3046
Comments
@antipath Do you have a sample document? /to @sriramkrish85 PTAL. |
I have included the amp-iframe extended component js and produced the following amp-iframe code <amp-iframe sandbox="allow-scripts allow-top-navigation" layout="responsive" src="https://somedomain.com/amp/ampiframe.html" height="311" width="320" resizable="" class="poll-container -amp-element -amp-layout-responsive -amp-layout-size-defined -amp-layout" frameborder="0" id="AMP_16" scrolling="no" style="height: 311px;"> <i-amp-sizer style="display: block; padding-top: 0px;"></i-amp-sizer> <i-amp-scroll-container class="amp-active"> </amp-iframe> then on the iframe page itself i have the following that post messages back to the parent
Thanks for your help! |
@sriramkrish85, The issue resolves once I put in "allow-same-origin", I guess I should hosting my iframe on another subdomain and apply "allow-same-origin" to see if that works |
Closing this bug as this is a non issue @ericlindley-g looks like we need to document this better or even remove the check for origin. Could you open a bug for this and we can discuss. |
Hi guys,
for the amp-iframe extended component if we leave out "allow-same-origin" value from the sandbox attribute, the amp-iframe does not resize.
What browsers are affected?
All browsers
Which AMP version is affected?
v. 1460655576651
The text was updated successfully, but these errors were encountered: