Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor placeholder creation by using createPlaceholderCallback #3212

Closed
mkhatib opened this issue May 13, 2016 · 2 comments
Closed

Refactor placeholder creation by using createPlaceholderCallback #3212

mkhatib opened this issue May 13, 2016 · 2 comments
Labels
P1: High Priority Related to: Performance
Milestone
Backlog Bugs

Comments

@mkhatib
Copy link
Contributor

mkhatib commented May 13, 2016

Now that we have #2846 in place. All (except of amp-youtube due to a hack that can't be avoided currently) should start using a similar method of amp-instagram to create their dynamic placeholders using createPlaceholderCallback.

This includes amp-brid-player, amp-jwplayer, amp-kaltura-player and amp-springboard-player.
@mkhatib mkhatib modified the milestones: Sprint: 2016-05-26, Backlog May 13, 2016
@dvoytenko
Copy link
Contributor

@mkhatib Do we have a separate bug tracking YouTube? It'd be great to see the status of our conversations with YouTube to address it in one place.

@mkhatib
Copy link
Contributor Author

mkhatib commented May 13, 2016 •
edited
Loading

@dvoytenko filed #3216 for amp-youtube.

@mkhatib mkhatib mentioned this issue Sep 30, 2016
Merged
@snyk-bot snyk-bot mentioned this issue Jul 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1: High Priority Related to: Performance
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
2 participants
@mkhatib @dvoytenko