Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 [Story Interactive] Remove link in interactives.html #34756

Merged
merged 5 commits into from
Jun 9, 2021
Merged

📖 [Story Interactive] Remove link in interactives.html #34756

merged 5 commits into from
Jun 9, 2021

Conversation

syydneyyhardister
Copy link
Contributor

Removed link in interactives.html

@mszylkowski mszylkowski requested review from mszylkowski and processprocess and removed request for kristoferbaxter June 8, 2021 17:18
@processprocess
Copy link
Contributor

Looks good! I wonder what the meta file is though. I think that needs to be removed from the PR.

@mszylkowski
Copy link
Contributor

@syydneyyhardister Can you run git submodule rm meta to see if the file changes are only the interactives.html file?

More info on https://stackoverflow.com/questions/1260748/how-do-i-remove-a-submodule

@mszylkowski mszylkowski enabled auto-merge (squash) June 9, 2021 15:27
@mszylkowski mszylkowski merged commit 6ecfc7b into ampproject:main Jun 9, 2021
@processprocess processprocess mentioned this pull request Jun 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@processprocess processprocess processprocess approved these changes

@mszylkowski mszylkowski mszylkowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syydneyyhardister @processprocess @mszylkowski