-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self host entire specific runtime #34946
Comments
/cc @ampproject/wg-infra Is this something we offer/can offer? |
@MadisonMiner I suspect this is due to AMP's 6 month retention policy for runtime versions. Any hard links to releases older than that are redirected to the current LTS version. You can find more details at the I2I at #25468, and the design review summary at #27071 (comment). Would it be possible for you to try a newer version of AMP and see if the behavior changes? Meanwhile, you've raised two interesting questions:
Let me check with the team and get back to you on these two. /cc @danielrozenberg |
@sebastianbenz regarding self hosting. |
@rsimha, we did upgrade to a new version last night. That did correct the issue. Thank you for checking on questions 1 and 2. |
That's excellent to hear, @MadisonMiner. Thanks for letting us know, and sorry about the additional trouble. Meanwhile, I do have an update on the questions raised by this bug.
|
It looks like #34971 covers the remaining work on this item. Closing this issue. @rsimha – Should we add some additional guidance regarding the 6 month timeline for allowed access to releases from the Google CDN? If you'd like to re-open for a relevant question, please ping here. Edit: Additional question. |
@rsimha, can you share any more information regarding fixing ww.js redirecting to amp-geo.js? A link to reference would be helpful. Thank you! |
@MadisonMiner The redirect issue was an internal Google issue impacting requests for versions >6 months old. @danielrozenberg might be able to answer additional questions. |
Description
We use AMP across many projects.
Testing everything with the weekly release, or even monthly with LTS, is challenging.
When using AMP in PWA, we self host the AMP runtime, to ensure a more reliable and stable environment.
However, even when we self host the runtime and set
<meta name="runtime-host">,
some files (like ww.js) are always served from the AMP cache.We would like to ensure that all files are self hosted when we self-host shadow-v0. (We understand why amp-geo would be an exception.)
Reproduction Steps
Even though we are self hosting, the self hosted shadow-v0 fetches this file from the AMP cache:
https://cdn.ampproject.org/rtv/012012232217000/ww.js
Tonight the 012012232217000 version of AMP (about 6 months old) started redirecting to: https://cdn.ampproject.org/lts/v0/amp-geo-0.1.js
Since the above link now redirects to amp-Geo, our site went down.
Relevant Logs
No response
Browser(s) Affected
Chrome, Firefox, Safari, Edge, UC Browser
OS(s) Affected
All
Device(s) Affected
All
AMP Version Affected
012012232217000
The text was updated successfully, but these errors were encountered: