Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defend against variable declaration issue #39383

Open
erwinmombay opened this issue Aug 16, 2023 · 0 comments
Open

defend against variable declaration issue #39383

erwinmombay opened this issue Aug 16, 2023 · 0 comments
Assignees
@erwinmombay
Labels
P1: High Priority Type: Bug WG: infra WG: runtime

Comments

@erwinmombay
Copy link
Member

Description

Figure out how we can prevent #39381, #39380

the issue cropped itself up in our module build but is non an issue in our nomodule build (because of function scoping)

Look into https://eslint.org/docs/latest/rules/no-redeclare if we can use this lint rule to prevent the issue

also look into why our tests was not able to catch the issue

Reproduction Steps

re introduce this renaming bug
54c0400

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erwinmombay erwinmombay

Labels
P1: High Priority Type: Bug WG: infra WG: runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erwinmombay