[amp-story-auto-ads] Fullscreen support ads

[MLB-Qwang]

Description

We've been trying to bring landscape mode to our Stories but the ad slides are currently being displayed in portrait mode.

Would it be possible for you guys to support fullscreen ads?

Alternatives Considered

I think the only alternative we have here is to break validation and use JS/CSS to remove the locked proportions defined here:

https://github.com/ampproject/amphtml/blob/main/extensions/amp-story-auto-ads/0.1/amp-story-auto-ads.css#L32

Additional Context

Here is what it looks like with our 16:9 ad asset in landscape mode:

[erwinmombay]

@ychsieh could you take a look at this when you get a chance?

[powerivq]

Hi,

@MLB-Qwang A few questions: are you using amp-story-auto-ads (with google ads manager)? Have you been able to fill the horizontal ads? We are aware of the ads size restrictions, but also want to make sure the ads services can support it as well.

[MLB-Qwang]

Hello!

1. Yes we are using amp-story-auto-ads with google ads manager.
2. Not sure what you mean here but I am able to request for horizontal ads and the correct horizontal asset is retrieved.

[powerivq]

@MLB-Qwang Gotcha. We are open to your proposal if you are willing to contribute. You already found the code reference .

[powerivq]

@MLB-Qwang Let us know what other helps you need, and if you are planning on moving on with this proposal.

[MLB-Qwang]

@powerivq Thank you! We do plan to go forward with this proposal but it may not be high priority for us right now.

[MLB-Qwang]

FYI, we are currently planning to start work on this some time early in 2025.