-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does an amp-search-bar extension make sense? #4071
Comments
The searchbox itself should be implemented with forms (#3343) once that's available. There's also a feature request for autocomplete in #3403 that could let you jump from AMP page to AMP page via a suggest experience. Search results pages themselves are out of scope for AMP because they are fundamentally not cacheable experiences. |
@rudygalfi you wrote "Search results pages themselves are out of scope for AMP because they are fundamentally not cacheable experiences." - is that the scope definition you are working to? It seems a bit narrow to me. Yes you want cacheable for the carousel/cdn. However there are plenty of cases where having a really fast mobile page, with a cached javascript framework that manages load priorities, would be a good thing. Our internal roadmap is to have entire sites be AMP when that's practical. That makes your statement somewhat worrying, can you clarify? |
OK, I think I was reasoning through this incorrectly. Disregard my previous comment "Search results pages themselves are out of scope for AMP because they are fundamentally not cacheable experiences" and replace with: Search results pages should work in AMP. Something to be mindful of is supporting GET behavior on the in-progress cc @cramforce for context on our earlier conversation and if you have anything to add to the discussion. |
Is it possible, using |
I will direct Google Custom Search folks to this thread so that they might respond. |
Important for our pages also! Currently, we have to launch a non-AMP JS page for Google Custom Search. GCS is important because it works well with our JSON-LD structures. |
Hi, are there any further outcomes of this? I could need this for an onlineshop I'm creating. |
@msowka-ninja Are you asking about Google Custom Search or searchbox functionality generally? For searchbox, I'd invite you to take a look at |
Half way there, Rudy. But how do we run a 'search' function on the form? We use 'amp-forms' for 'registration' and 'requests' by posting JSON from user submissions. But we don't see how to build an 'amp-compliant-form' that searches the JSON-LD structures on AMP pages. From our perspective, cache is not an issue, as the JSON-LD is part of the cache. The issue is using search to find the amp-page with the JSON-LD 'of interest'. A secondary issue is finding non-JSON-LD strings that can be registered with Google Custom Search. There, your point about cache come into play because those strings cannot be stored in a amp-compliant manner. So, for version 1, we propose to limit search to content in the JSON-LD. |
closing for #9785 which is implemented |
I'm currently working on a dictionary definition AMP sample, and one thing very common to dictionary definitions is the ability to easily change the word you are looking at.
It occurred to me that the same could be said if I am in an article, I may want to search for another article on a different topic.
The search box for a dictionary definition could be straight forward-- a simple bit of javascript that changes the url. The article search is trickier-- it could mean integrating with third party search engines (CSE, for example).
Outside the scope of AMP?
The text was updated successfully, but these errors were encountered: