You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current PR to introduce.user-valid and .user-invalid to inputs, fieldsetand form make the following assumptions that we'd like to discuss and try to loop in people that know what's might be the future of the :user-invalid spec behavior.
The user types a character in inputA it becomes .user-valid
The user removes the character from inputA it becomes .user-invalid - this is also propagated to the fieldset marking it also .user-invalid
The user types the character again inputA becomes .user-valid and fieldset is still user-invalid
This behavior seems a bit off (specially the last part), we'd like to understand a bit better what's the spec'd behavior would be for this part so we can match that. Some ideas for what might make a better behavior:
Only propagate .user--mode to fieldset if ALL its inputs are now in .user--mode.
One main issue also seems to be inconsistencies between Chrome and other browsers implementation of fieldset.checkValidity where Chrome seems to evaluate based on whether the fieldset has invalid/valid inputs and all other browsers always return true - This being tracked in #3898.
The text was updated successfully, but these errors were encountered:
Would it make sense to skip the validation on fieldset and not add any .-user- fields to fieldset since all browsers besides chrome return true for the fieldsets validation anyways?
The AMP community has been working nonstop to make AMP better, but somehow we've still managed to grow an enormous backlog of open issues. This has made it difficult for the community to prioritize what we should work on next.
A new process is on the way and to give it a chance for success we will be closing issues that have not been updated in awhile.
If this issue still requires further attention, simply reopen it. Please verify first whether the feature proposal is still relevant.
We really appreciate the contribution! Thank you for bearing with us as we drag ourselves out of the issue abyss. :)
The current PR to introduce
.user-valid
and.user-invalid
toinput
s,fieldset
andform
make the following assumptions that we'd like to discuss and try to loop in people that know what's might be the future of the:user-invalid
spec behavior.Demo of current behavior can be found here.
The current behavior is:
.user-
-modeinputA
it becomes.user-valid
inputA
it becomes.user-invalid
- this is also propagated to thefieldset
marking it also.user-invalid
inputA
becomes.user-valid
andfieldset
is stilluser-invalid
This behavior seems a bit off (specially the last part), we'd like to understand a bit better what's the spec'd behavior would be for this part so we can match that. Some ideas for what might make a better behavior:
.user-
-mode tofieldset
if ALL its inputs are now in.user-
-mode.One main issue also seems to be inconsistencies between Chrome and other browsers implementation of
fieldset.checkValidity
where Chrome seems to evaluate based on whether the fieldset has invalid/valid inputs and all other browsers always returntrue
- This being tracked in #3898.The text was updated successfully, but these errors were encountered: