Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildExtensions gets recursively called which causes multiple watchers on the extensions to get created #44

Closed
erwinmombay opened this issue Sep 9, 2015 · 1 comment
Closed

buildExtensions gets recursively called which causes multiple watchers on the extensions to get created #44

erwinmombay opened this issue Sep 9, 2015 · 1 comment
Assignees
@cramforce

Comments

@erwinmombay
Copy link
Member

https://github.com/ampproject/amphtml/blob/master/gulpfile.js#L60

we keep passing watch: true options which doubles the amount of watchers every time build extensions is ran.

this affects the bundling of the files as bundling gets slower and slower.
@cramforce
Copy link
Member

Nice :)

@cramforce cramforce self-assigned this Sep 10, 2015
@cramforce cramforce mentioned this issue Sep 10, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramforce cramforce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cramforce @erwinmombay