Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defense in depth: ensure that templates do not generate __amp_source_origin to avoid CSRF #4661

Closed
dvoytenko opened this issue Aug 23, 2016 · 1 comment
Closed

Defense in depth: ensure that templates do not generate __amp_source_origin to avoid CSRF #4661

dvoytenko opened this issue Aug 23, 2016 · 1 comment
Assignees
@mkhatib
Milestone
To be deprecated ...

Comments

@dvoytenko
Copy link
Contributor

URLs are handled in templates outputs by sanitizer.js in resolveUrlAttr. This method need to assert that __amp_source_origin query parameter is not present since the template outputs cannot be run through the validator.

/cc @molnarg @Gregable
@mkhatib mkhatib added this to the Current milestone Aug 23, 2016
@mkhatib
Copy link
Contributor

mkhatib commented Aug 23, 2016

Should this throw errors or just strip the __amp_source_origin?

@mkhatib mkhatib mentioned this issue Aug 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkhatib mkhatib

Labels
None yet
Projects
None yet
Milestone
To be deprecated - Current
Development

No branches or pull requests
2 participants
@mkhatib @dvoytenko